Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override default-host configuration #279

Merged
merged 3 commits into from
Nov 7, 2020
Merged

Add ability to override default-host configuration #279

merged 3 commits into from
Nov 7, 2020

Conversation

dave-pollock
Copy link
Contributor

Pull Request (PR) description

Add ability to override default-host configuration. The default-host configuration is used to control the "host" property which Splunk will use to identify the forwarder. The current behaviour forces the default-host to match the server's $HOSTNAME. In my environment we prefer to customise this name to identify the region and environment for the forwarder (info we don't normally include in the server's hostname).

The default behaviour is maintained so this shouldn't break any existing setup. It just adds the ability to override it if required.

This Pull Request (PR) fixes the following issues

N/A

@dave-pollock
Copy link
Contributor Author

I don't really see how these test failures could be related to my change?

Please let me know if I'm missing something. Cheers!

@dave-pollock
Copy link
Contributor Author

@bastelfreak since you seem to be the most active maintainer would you mind reviewing this PR if you have a minute free? Thanks.

@dave-pollock
Copy link
Contributor Author

@ghoneycutt perhaps you could take a look at this if you have a moment?

@vox-pupuli-tasks
Copy link

Dear @dave-pollock, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@bastelfreak
Copy link
Member

@dave-pollock can you please rebase this against our latest master? The git history is a bit clumsy at the moment.

@dave-pollock dave-pollock reopened this Nov 5, 2020
@dave-pollock
Copy link
Contributor Author

@bastelfreak I've rebased.

@bastelfreak bastelfreak added enhancement New feature or request and removed needs-rebase tests-fail labels Nov 7, 2020
manifests/params.pp Outdated Show resolved Hide resolved
@bastelfreak bastelfreak merged commit 7add721 into voxpupuli:master Nov 7, 2020
@dave-pollock dave-pollock deleted the add-default-host-override branch November 8, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants