Merge branch 'bugfix-orm-is-dirty' of https://github.com/tentwofour/i…

…diorm into tentwofour-bugfix-orm-is-dirty
voku · Dec 14, 2016 · 43ec268 · 43ec268
2 parents b648c49 + 431684f
commit 43ec268
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/idiorm.php b/idiorm.php
@@ -2042,7 +2042,7 @@ protected function _set_orm_property($key, $value = null, $expr = false) {
          * object was saved.
          */
         public function is_dirty($key) {
-            return isset($this->_dirty_fields[$key]);
+            return array_key_exists($key, $this->_dirty_fields);
         }
 
         /**

diff --git a/test/ORMTest.php b/test/ORMTest.php
@@ -43,9 +43,15 @@ public function testIsNew() {
     public function testIsDirty() {
         $model = ORM::for_table('test')->create();
         $this->assertFalse($model->is_dirty('test'));
-        
+
         $model = ORM::for_table('test')->create(array('test' => 'test'));
         $this->assertTrue($model->is_dirty('test'));
+
+        $model->test = null;
+        $this->assertTrue($model->is_dirty('test'));
+
+        $model->test = '';
+        $this->assertTrue($model->is_dirty('test'));
     }
 
     public function testArrayAccess() {