core-services/03-console-setup.sh: respect localtime hwclock #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When TIMEZONE was unset or empty, the resulting empty TZ variable in the environment caused hwclock to set the timezone to UTC and ignore the value of /etc/localtime. Only set TZ when TIMEZONE is non-empty. Thanks to quinq in #voidlinux for finding the root cause of the bug. hwclock(8): The system timezone is configured by the TZ environment variable or the /etc/localtime file, as tzset(3) would interpret them. tzset(3): If the TZ variable does appear in the environment, but its value is empty, or its value cannot be interpreted using any of the formats specified below, then Coordinated Universal Time (UTC) is used. Fixes: 6394a10 (core-services/02-console-setup.sh: setup HARDWARECLOCK if set.)
deepcube
force-pushed
the
emg-localtime
branch
from
3d5d335
to
fe3bfc6
Compare
deepcube
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TIMEZONE was unset or empty, the resulting empty TZ variable in
the environment caused hwclock to set the timezone to UTC and ignore
the value of /etc/localtime. Only set TZ when TIMEZONE is non-empty.
Thanks to quinq in #voidlinux for finding the root cause of the bug.
hwclock(8):
tzset(3):
Fixes: 6394a10 (core-services/02-console-setup.sh: setup HARDWARECLOCK if set.)