Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forks to publish docker images #229

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Allow forks to publish docker images #229

merged 1 commit into from
Nov 7, 2023

Conversation

4n4n4s
Copy link
Contributor

@4n4n4s 4n4n4s commented Sep 27, 2023

No description provided.

@vogler
Copy link
Owner

vogler commented Oct 27, 2023

Thanks a lot!
As I understand, this PR now allows forks to publish their own image if logins are set.
What's the planned behavior? Images for PRs here aren't built. I guess they should be built but just not pushed.
I also had some comment there that pull_request only triggered on creation, not on every push, but not sure if that's true.

@vogler
Copy link
Owner

vogler commented Oct 27, 2023

(Also, probably best to avoid force-pushing since it may screw up reviews etc.)

@4n4n4s
Copy link
Contributor Author

4n4n4s commented Oct 27, 2023

Thanks a lot!

As I understand, this PR now allows forks to publish their own image if logins are set.

Correct

What's the planned behavior? Images for PRs here aren't built. I guess they should be built but just not pushed.

I introduced it so that on forks you can also have your image and then test it quickly without requiring the merge here to have it somewhere easily accessible. Could be quite helpful for future store and quick/bugfixes.

I also had some comment there that pull_request only triggered on creation, not on every push, but not sure if that's true.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request according to this it also triggers on "edited".

@vogler vogler merged commit 5fda138 into vogler:main Nov 7, 2023
1 check passed
vogler added a commit that referenced this pull request Nov 7, 2023
@vogler
Copy link
Owner

vogler commented Nov 7, 2023

Made some changes, probably some more adjustments are needed to get the desired behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants