Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'bullseye' Debian version instead of unspecified one #266

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

Van0SS
Copy link
Contributor

@Van0SS Van0SS commented Jul 1, 2023

This change is solving #262

Debian 12 "Bookworm" was released in early June, which was picked up by python docker image and as a result it broke Azure client.

This change would specify precise version of Debian, which is a good practice anyway. After the issue is solved version could be upgraded to 12.

Running in the container:
Before:

# cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

# openssl version
OpenSSL 3.0.9 30 May 2023 (Library: OpenSSL 3.0.9 30 May 2023)

After:

# cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

# openssl version
OpenSSL 1.1.1n  15 Mar 2022

@KShah707
Copy link
Contributor

KShah707 commented Jul 1, 2023

The azure SDK setup guide lists a bunch of dependencies to install on Debian. Do you need to add any of those to the Dockerfile too?

@Van0SS
Copy link
Contributor Author

Van0SS commented Jul 2, 2023

It works with current Dockerfile after the change, so I think it should be fine, good catch though

Copy link
Contributor

@ajar98 ajar98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajar98 ajar98 merged commit 159d153 into vocodedev:main Jul 2, 2023
4 checks passed
KShah707 pushed a commit to KShah707/vocode-python that referenced this pull request Jul 5, 2023
m5a0r7 pushed a commit to m5a0r7/vocode-python that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants