Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix terminate error for AssemblyAITranscriber #177

Merged
merged 2 commits into from
Jun 2, 2023
Merged

fix terminate error for AssemblyAITranscriber #177

merged 2 commits into from
Jun 2, 2023

Conversation

m-ods
Copy link
Contributor

@m-ods m-ods commented May 31, 2023

  • neatly terminates AssemblyAITranscriber by sending terminate message correctly as text instead of audio data

ajar98
ajar98 previously requested changes May 31, 2023
vocode/streaming/transcriber/assembly_ai_transcriber.py Outdated Show resolved Hide resolved
@ajar98 ajar98 assigned HHousen and unassigned m-ods Jun 1, 2023
Copy link
Contributor

@HHousen HHousen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the benchmarking script. Appears to fix the issue! Nice!

@HHousen HHousen merged commit 0d0675b into vocodedev:main Jun 2, 2023
4 checks passed
@m-ods m-ods deleted the aai-rt-terminate-fix branch June 5, 2023 11:41
m5a0r7 pushed a commit to m5a0r7/vocode-python that referenced this pull request Oct 19, 2023
* fix terminate error for AssemblyAITranscriber

* fixed super().terminate()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants