Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPT response as text aswell #136

Merged
merged 6 commits into from
Jun 5, 2023
Merged

Conversation

yantao0527
Copy link
Contributor

Support to add GPT response as text aswell

Just showing the idea, need to debug

@HHousen
Copy link
Contributor

HHousen commented May 26, 2023

Hello. Thanks for working on this! The message text probably shouldn't be attached to the AudioMessage. Do you think you could use the EventsManager for this?

@yantao0527
Copy link
Contributor Author

The idea of using event subscription is better than the one of extension audio message. I'm going to update the code via event today.

@yantao0527
Copy link
Contributor Author

@HHousen I've finished update code and debug successfully.

@HHousen
Copy link
Contributor

HHousen commented Jun 2, 2023

Looks good! Just want to fix the scroll bar at vocodedev/vocode-react-demo#4 before merging.

@yantao0527
Copy link
Contributor Author

  • optimize the code to merge the transcript of same sender.
  • show scroll bar, but it's ugly.

@HHousen HHousen merged commit acc103c into vocodedev:main Jun 5, 2023
0 of 4 checks passed
@HHousen HHousen mentioned this pull request Jun 5, 2023
m5a0r7 pushed a commit to m5a0r7/vocode-python that referenced this pull request Oct 19, 2023
* audio msg ext

* switch from extension audio message to transcript event subscription

* pass debug

* show transcripts on UI
@shalabhsingh
Copy link

shalabhsingh commented Jan 29, 2024

@yantao0527 I have been using the useConversation hook as shown here to receive transcripts on the frontend, but I only receive the transcript for the initial message (BaseMessage) set up in my client backend. I believe something has changed since this was merged?

Note-

  1. I have already set subscribeTranscript to be true in the useConversation hook.
  2. on debugging, I found out that message of type websocket_transcript is received only once for the initial message, which is causing the error

Edit (for others who might struggle with this)-
This error is resolved in the latest version of the code in the latest commit, but is not a part of the latest release v0.1.111. It's better to pip install vocode from the latest commit instead i believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants