Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor API building data from vch model #7991

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AngieCris
Copy link
Contributor

@AngieCris AngieCris commented May 25, 2018

[specific ci=23-03-VCH-Create]

Work in progress

  1. Categorize API input VCH model
  2. Process each category of VCH input fields separately in decode package

Now API decode package directly translates VCH input swagger model to install/data struct.
API no longer uses CLI create.Create object. API directly works with install/data to create a VCH.

@AngieCris AngieCris self-assigned this May 25, 2018
@AngieCris AngieCris requested a review from zjs May 25, 2018 03:06
@codecov-io
Copy link

codecov-io commented May 26, 2018

Codecov Report

Merging #7991 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7991   +/-   ##
=======================================
  Coverage   26.22%   26.22%           
=======================================
  Files          37       37           
  Lines        5243     5243           
=======================================
  Hits         1375     1375           
  Misses       3762     3762           
  Partials      106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e465c53...6856cf6. Read the comment docs.

@zjs zjs assigned zjs and unassigned AngieCris Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants