XML serialization for certain types is broken on Python 3 #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XML serialization does not work for certain types on Python 3. This is best illustrated by example:
On Python 2.7:
On Python 3.4:
At SoapAdapter.py:395 (in SoapSerializer._Serialize), the object is checked for isinstance(val, text_type). The result of that comparison is different across versions: on Python 2.7, text_type is 'unicode'; on Python 3.4, text_type is 'str'. As a result, on Python 2.7, val is explicitly converted to a str, whereas no such conversion happens in 3.4. Also, this object has a 'replace' attribute, which is a real function on str objects, but on a FileOperation object, the 'replace' attribute is not a function. Thus, _Serialize fails at runtime when calling replace() on Python 3.4.