refactor: ansible roles

[tenthirtyam]

Summary of Pull Request

Refactors:

• Used of fully qualified module names.
• Well-formed and named blocks.
• Well-formed YAML.
• Moved the when directive to top of blocks.
• Prefixed task_names var with role name.
• Added some changes to silence linter, as needed.
• Moved SLE values to var/main.yml.

Type of Pull Request

• This is a bugfix. type/bug
• This is an enhancement or feature. type/feature or type/enhancement
• This is a documentation update. type/docs
• This is a refactoring update. type/refactor
• This is a chore. type/chore
• This is something else.
  Please describe:

Related to Existing Issues

Ref: #932

Test and Documentation Coverage

• Tests have been completed.
• Documentation has been added or updated.

Breaking Changes?

• Yes, there are breaking changes.
• No, there are no breaking changes.

[tenthirtyam]

Hi @shaneholloman 👋 - would you mind reviewing this pull request based on the content you provided in #932?

[shaneholloman]

Generally looks very good...

• there are some inconsistencies (my fault) with quotes - mode: '0644' vs "0644" (single quotes are a preference) I noticed yesterday that running ansible-lint --fix will normalize all the quoting bits for free, very handy: single vs double and will also clean up items like the name: "Quoting as well" changes to name: Quoting as well so maybe that be could run as a separate test/commit?

• If I even understand this correctly, I'd like to let vmware tools tell us which distro flavor it sees, rather than squashing it to simply: 'other5xLinux64Guest' - however I may not understand fully how vmware-tools works in this regard.

• I see you kept the suse refactor for

  full_module_path: "{{ base_sle_module_name }}/{{ base_sle_module_version }}/{{ base_sle_architecture }}"
  

  Note: I haven't test that. but syntaxually it checks for me.

---

Without personally testing on very distro, looks good to me ... that said I'll be testing every distro in the project (except the paid distros Rhel and Suse) next week.

awesome work as usual, this project is very helpful and Im grateful its maintained so well.

---

aside: working on a clean way to let users include their additional playbooks/roles as this something we do here at work.

[tenthirtyam]

An update has been force-pushed in abc8e53 with the auto fixes by ansible-lint.

[shaneholloman]

nice work.

[Codehunter-py]

Hi

Currently, I receive an error during the provision of the VM. Is it fixed in this pr?

    vsphere-iso.linux-rocky: TASK [users : Configure the operating system users.] ***************************
    vsphere-iso.linux-rocky: The error appears to be in '/builds/itops/packer-examples-for-vsphere/<sensitive>/roles/users/tasks/linux.yml': line 24, column 3, but may
    vsphere-iso.linux-rocky: be elsewhere in the file depending on the exact syntax problem.
    vsphere-iso.linux-rocky:
    vsphere-iso.linux-rocky: The offending line appears to be:
    vsphere-iso.linux-rocky:
    vsphere-iso.linux-rocky: # Tasks for managing the authorized keys for the local users.
    vsphere-iso.linux-rocky: - name: Managing the authorized keys for the local users.
    vsphere-iso.linux-rocky:   ^ here
==> vsphere-iso.linux-rocky: Error executing Ansible: Non-zero exit status: exit status 4

KR
Ibrahim

[burnsjared0415]

i tested this on Rocky 9.4 and 8.10 with out running into this issue. Ran through build around 4 times with success on each run