Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added cloud-init to sles #919

Merged
merged 1 commit into from
May 10, 2024
Merged

feat: added cloud-init to sles #919

merged 1 commit into from
May 10, 2024

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented May 10, 2024 •
edited by tenthirtyam
Loading

Summary of Pull Request

Added the cloud-init option for SLES 15.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #691 691

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@burnsjared0415 burnsjared0415 requested a review from a team as a code owner May 10, 2024 13:50
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label May 10, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat/add-support-for-cloud-init-on-SUSE branch from 8ae89d2 to c82d33f Compare May 10, 2024 13:51
@burnsjared0415 @tenthirtyam
feat: added cloud-init to sles
4ba372b 
Added the cloud-init option for SLES 15.

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feat/add-support-for-cloud-init-on-SUSE branch from c82d33f to 4ba372b Compare May 10, 2024 14:02
@tenthirtyam tenthirtyam changed the title Feat: add support for cloud-init on SUSE feat: added cloud-init to sles May 10, 2024
@tenthirtyam tenthirtyam added this to the v0.20.0 milestone May 10, 2024
@tenthirtyam tenthirtyam added the type/enhancement Enhancement label May 10, 2024
@tenthirtyam tenthirtyam requested review from tenthirtyam and removed request for GaryJBlake May 10, 2024 14:03
tenthirtyam
tenthirtyam approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!!!

@tenthirtyam tenthirtyam merged commit a2fb885 into vmware-samples:develop May 10, 2024
@tenthirtyam tenthirtyam mentioned this pull request May 10, 2024
Closed
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@burnsjared0415 burnsjared0415

Labels
cla-not-required Contributor License Agreement Not Required type/enhancement Enhancement
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@burnsjared0415 @tenthirtyam @vmwclabot