Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added cloud-init to photon 4 and 5 #900

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Apr 23, 2024

Summary of Pull Request

  • Adds option to enable cloud-init on VMware Photon OS 4.
  • Adds option to enable cloud-init on VMware Photon OS 5.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@burnsjared0415 burnsjared0415 requested a review from a team as a code owner April 23, 2024 18:49
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Apr 23, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat-/add-cloud-init-to-Photon-4/5 branch from fce2448 to 8c4beba Compare April 23, 2024 18:50
@tenthirtyam tenthirtyam requested review from tenthirtyam and removed request for GaryJBlake April 23, 2024 18:52
@tenthirtyam tenthirtyam changed the title feat:/add cloud-init Photon 4/5 feat: added cloud-init to photon 4 and 5 Apr 23, 2024
@tenthirtyam tenthirtyam force-pushed the feat-/add-cloud-init-to-Photon-4/5 branch from 8c4beba to c6edc50 Compare April 23, 2024 18:58
@tenthirtyam tenthirtyam linked an issue Apr 23, 2024 that may be closed by this pull request
1 task
@tenthirtyam tenthirtyam added this to the v0.20.0 milestone Apr 23, 2024
@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Apr 23, 2024
@tenthirtyam tenthirtyam force-pushed the feat-/add-cloud-init-to-Photon-4/5 branch from c6edc50 to 39f1bc1 Compare April 23, 2024 19:00
tenthirtyam
tenthirtyam previously approved these changes Apr 23, 2024
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

- Adds option to enable cloud-init on VMware Photon OS 4.
- Adds option to enable cloud-init on VMware Photon OS 5.

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feat-/add-cloud-init-to-Photon-4/5 branch from 39f1bc1 to 8162eb3 Compare April 23, 2024 19:04
@tenthirtyam tenthirtyam merged commit cff34d1 into vmware-samples:develop Apr 23, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required type/enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for cloud-init for each Linux distribution
3 participants