Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: option to enable cloud-init on rhel 9 and 8 #888

Merged
merged 1 commit into from
Apr 21, 2024
Merged

feat: option to enable cloud-init on rhel 9 and 8 #888

merged 1 commit into from
Apr 21, 2024

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Apr 20, 2024 •
edited by tenthirtyam
Loading

Summary of Pull Request

  • Added the cloud-init option for RHEL 9.
  • Added the cloud-init option for RHEL 8.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Ref: #691

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@burnsjared0415 burnsjared0415 requested a review from a team as a code owner April 20, 2024 00:36
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Apr 20, 2024
tenthirtyam
tenthirtyam requested changes Apr 20, 2024
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam changed the title feat: added cloud-init to RHEL 8.9 and 9.3 feat: added cloud-init to rhel 9 and 8 Apr 21, 2024
@tenthirtyam tenthirtyam removed the request for review from GaryJBlake April 21, 2024 21:40
@tenthirtyam tenthirtyam changed the title feat: added cloud-init to rhel 9 and 8 feat: option to enable cloud-init on rhel 9 and 8 Apr 21, 2024
@burnsjared0415 @tenthirtyam
feat: option to enable cloud-init on rhel 9 and 8
5c07b06 
- Added the cloud-init option for RHEL 9.
- Added the cloud-init option for RHEL 8.

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam self-requested a review April 21, 2024 21:46
tenthirtyam
tenthirtyam approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tenthirtyam tenthirtyam merged commit 4817e9d into vmware-samples:develop Apr 21, 2024
@tenthirtyam tenthirtyam mentioned this pull request Apr 21, 2024
Closed
1 task
tenthirtyam pushed a commit that referenced this pull request Apr 22, 2024
@burnsjared0415 @tenthirtyam
feat: option to enable cloud-init on rhel 9 and 8 (#888)
1216f30 
- Added the cloud-init option for RHEL 9.
- Added the cloud-init option for RHEL 8.

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam added this to the v0.20.0 milestone Apr 22, 2024
@tenthirtyam tenthirtyam linked an issue Apr 23, 2024 that may be closed by this pull request
Add support for cloud-init for each Linux distribution #691
Closed
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@burnsjared0415 burnsjared0415

Labels
cla-not-required Contributor License Agreement Not Required
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.

Add support for cloud-init for each Linux distribution
3 participants
@burnsjared0415 @tenthirtyam @vmwclabot