Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to enable cloud-init on debian 12.5 #883

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Apr 17, 2024

Summary of Pull Request

Added support for cloud-init on Debian 12.5.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Ref: #691

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Apr 17, 2024
Added cloud Init on Debian 12.5

Signed-off-by: Jared Burns <[email protected]>
Added cloud Init on Debian 12.5

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feat-/add-cloud-init-to-linux branch from fb6228d to caf1711 Compare April 18, 2024 21:03
@burnsjared0415 burnsjared0415 changed the title feat: add cloud init to Debian 12.5 - WORK-IN-PROGRESS feat: add cloud init to Debian 12.5 Apr 18, 2024
@burnsjared0415 burnsjared0415 marked this pull request as ready for review April 18, 2024 21:56
@burnsjared0415 burnsjared0415 requested a review from a team as a code owner April 18, 2024 21:56
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit to reset.

docs/index.md Outdated Show resolved Hide resolved
ansible/roles/configure/tasks/debian.yml Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Apr 19, 2024
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the CHANGELOG.md under v0.20.0?

@tenthirtyam tenthirtyam force-pushed the feat-/add-cloud-init-to-linux branch from 66f8bc4 to c67b0ff Compare April 19, 2024 14:46
Adds option to enable cloud-init on Debian 12.5.

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feat-/add-cloud-init-to-linux branch from c67b0ff to 07ce5a4 Compare April 19, 2024 14:47
@tenthirtyam tenthirtyam changed the title feat: add cloud init to Debian 12.5 feat: option to enable cloud-init on debian 12.5 Apr 19, 2024
@tenthirtyam tenthirtyam merged commit 6c117ea into vmware-samples:develop Apr 19, 2024
@tenthirtyam tenthirtyam added this to the v0.20.0 milestone Apr 22, 2024
@tenthirtyam tenthirtyam removed the request for review from GaryJBlake April 22, 2024 16:00
@tenthirtyam tenthirtyam linked an issue Apr 23, 2024 that may be closed by this pull request
1 task
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required type/enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for cloud-init for each Linux distribution
3 participants