Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows pwsh provisioner #879

Merged
merged 3 commits into from
Apr 15, 2024
Merged

fix: windows pwsh provisioner #879

merged 3 commits into from
Apr 15, 2024

Conversation

tenthirtyam
Copy link
Contributor

Summary of Pull Request

Removes the PowerShell provisioner for Windows 11 and 10 as it's not required currently after the transition to Ansible.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #875

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

burnsjared0415 and others added 2 commits April 15, 2024 11:43
Adds a script (`./download.sh`) and a configuration (`project.json`) to assist in the download of the guest operating systems.

Signed-off-by: Jared Burns <[email protected]>
Co-authored-by: Ryan Johnson <[email protected]>
Removes the PowerShell provisioner for Windows 11 and 10 as it's not required currently after the transition to Ansible.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added the type/bug Bug label Apr 15, 2024
@tenthirtyam tenthirtyam added this to the v0.19.1 milestone Apr 15, 2024
@tenthirtyam tenthirtyam self-assigned this Apr 15, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 15, 2024 15:45
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Apr 15, 2024
@tenthirtyam tenthirtyam merged commit 1dcc44e into develop Apr 15, 2024
@tenthirtyam tenthirtyam deleted the fix/windows-pwsh-prov branch April 15, 2024 15:47
tenthirtyam added a commit that referenced this pull request Apr 15, 2024
Removes the PowerShell provisioner for Windows 11 and 10 as it's not required currently after the transition to Ansible.

Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam added a commit that referenced this pull request Apr 15, 2024
* fix: windows pwsh provisioner (#879)

Removes the PowerShell provisioner for Windows 11 and 10 as it's not required currently after the transition to Ansible.

Signed-off-by: Ryan Johnson <[email protected]>

* feat: gos iso download automation (#874)

Adds a script (`./download.sh`) and a configuration (`project.json`) to assist in the download of the guest operating systems.

Signed-off-by: Jared Burns <[email protected]>
Co-authored-by: Ryan Johnson <[email protected]>

* feat: added iso check

Added a check for an existing ISO before starting download to prevent an unecessart download from starting,

Signed-off-by: Jared Burns <[email protected]>

---------

Signed-off-by: Ryan Johnson <[email protected]>
Signed-off-by: Jared Burns <[email protected]>
Co-authored-by: Ryan Johnson <[email protected]>
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required type/bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PowerShell provisioner error on Windows 10 and 11
3 participants