Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable content library #861

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

tenthirtyam
Copy link
Contributor

Summary of Pull Request

  • Adds option to enable a content library to source all guest operating system ISOs or use a datastore path. Defaults to false, disabled. Set common_iso_content_library_enabled to true to enable use of a content library for all guest operating system ISOs.

  • Adds option to enable a content library for the placement of virtual machine images builds. Defaults to true, enabled. Set common_content_library_enabled to false to disable use of a content library for saving virtual machine image builds.

  • Formatting / linting.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #807

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Note the change from common_content_library_name to common_content_library.

@tenthirtyam tenthirtyam added this to the .Next milestone Mar 29, 2024
@tenthirtyam tenthirtyam self-assigned this Mar 29, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner March 29, 2024 00:37
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Mar 29, 2024
@tenthirtyam
Copy link
Contributor Author

@gcblack - mind taking this for a spin?

@tenthirtyam tenthirtyam force-pushed the feat/enable-content-library branch 11 times, most recently from 435ada4 to 8512c98 Compare April 4, 2024 16:44
- Adds option to enable a content library to source all guest operating system ISOs or use a datastore path. Defaults to `false`, disabled.
  Set `common_iso_content_library_enabled` to `true` to enable use of a content library for all guest operating system ISOs.

- Adds option to enable a content library for the placement of virtual machine images builds. Defaults to `true`, enabled.
  Set `common_content_library_enabled` to `false` to disable use of a content library for saving virtual machine image builds.

- Formatting / linting.
@tenthirtyam tenthirtyam merged commit d23da87 into develop Apr 4, 2024
@tenthirtyam tenthirtyam deleted the feat/enable-content-library branch April 4, 2024 19:15
Copy link

github-actions bot commented May 5, 2024

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required type/chore Chore type/enhancement Enhancement type/refactor Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for an option to use a content library for ISOs
2 participants