Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance check to regenerate SSH keys #795

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

tenthirtyam
Copy link
Contributor

Summary of Pull Request

Enhances the Ansible task to use copy versus lineinfile to create /etc/rc.local with a check for all SSH host keys.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #793

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Enhances the Ansible task to use `copy` versus `lineinfile` to create `/etc/rc.local` with a check for all SSH host keys.

Ref: #793

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added the type/bug Bug label Dec 14, 2023
@tenthirtyam tenthirtyam added this to the .Next milestone Dec 14, 2023
@tenthirtyam tenthirtyam self-assigned this Dec 14, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner December 14, 2023 03:02
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Dec 14, 2023
@tenthirtyam tenthirtyam merged commit 11bfa2b into develop Dec 14, 2023
1 check passed
@tenthirtyam tenthirtyam deleted the fix/enhance-egenerate-ssh-keys branch December 14, 2023 03:03
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required type/bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants