Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove checksum #722

Merged
merged 1 commit into from
Oct 9, 2023
Merged

chore: remove checksum #722

merged 1 commit into from
Oct 9, 2023

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Oct 6, 2023

Summary of Pull Request

Removes the use of the following as they are not needed since the ISOs are not being downloaded by the plugin and are expected to be present and already verified by the user after download.

  • iso_checksum_type
  • iso_checksum_value

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the type/chore Chore label Oct 6, 2023
@tenthirtyam tenthirtyam added this to the .Next milestone Oct 6, 2023
@tenthirtyam tenthirtyam self-assigned this Oct 6, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 6, 2023 21:06
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Oct 6, 2023
@tenthirtyam tenthirtyam added type/refactor Refactor and removed type/chore Chore labels Oct 6, 2023
@tenthirtyam tenthirtyam force-pushed the chore/remove-checksum branch 2 times, most recently from ecdf323 to 7253432 Compare October 6, 2023 21:09
Removes the use of the following as they are not needed since the ISOs are not being downloaded by the plugin and are expected to be present and already verified by the user after download.
- `iso_checksum_type`
- `iso_checksum_value`

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam merged commit 885ef15 into develop Oct 9, 2023
@tenthirtyam tenthirtyam deleted the chore/remove-checksum branch October 9, 2023 13:43
Copy link

github-actions bot commented Nov 9, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required type/refactor Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants