Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor manifest output location. #66

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Refactor manifest output location. #66

merged 3 commits into from
Sep 29, 2021

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Update manifest output location.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Context of the Pull Request*

  • Add default manifests/ directory.
  • Update .gitignore to ignore manifests/*.json.
  • Add locals for path_manifest.
  • Update post-processor to use ${local.path_manifest}.

Also:

  • Restore autounattend.pkrtpl.hcl mistakingly deleted in Rename cd to data #64.
  • Update linux-*.pkrvars.hcl formatting using packer fmt -recursive

Related to Existing Issues

Issue Number: #55
Closes: #55

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

- Add default `manifests/` directory.
- Update `.gitignore` to ignore `manifests/*.json`.
- Add locals for `path_manifest`.
- Update post-processor to use `${local.path_manifest}`.
Update `linux-*.pkrvars.hcl` formatting using `packer fmt -recursive`
Restoring  `autounattend.pkrtpl.hcl` mistakingly deleted in #64.
@tenthirtyam tenthirtyam self-assigned this Sep 29, 2021
@tenthirtyam tenthirtyam merged commit 7ad08cd into vmware-samples:main Sep 29, 2021
@tenthirtyam tenthirtyam deleted the refactor-manifests branch September 29, 2021 22:47
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Simply manifest output
1 participant