Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for release v21.09.1 #38

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Update for release v21.09.1 #38

merged 3 commits into from
Sep 16, 2021

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Sep 16, 2021

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Refactored issue templates to use GitHub custom issue forms.
  • Updated the Rocky Linux build to use UEFI; however without secure boot.
  • Updated the defaults in common.pkvars.hcl to use hardware version 19, which provides the best performance and latest features available in ESXi 7.0 U2. Refer to the VMware vSphere 7.0 product documentation if using a previous release
  • Refactored all builds to pass the language, keyboard, and timezone to the configuration files.
  • Refactored all builds with input variable definitions separated into variables.pkr.hcl.
  • Refactored all builds to use <build>.auto.pkvars.hcl for input variables the and <build>.pkr.hcl for the template configurations, with simplified names for <build>.
  • Refactored all builds to use ${path.cwd}/output/ as the path for the manifest post-processor.
  • Updated README.md.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Context of the Pull Request*

Minor refactoring and enhancement update.

Related to Existing Issues

Issue Number: None

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Updated the defaults in `common.pkvars.hcl` to use hardware version 19, which provides the best performance and latest features available in ESXi 7.0 U2.
* Refactored all builds to pass the language, keyboard, and timezone to the configuration files.
* Refactored all builds with input variable definitions separated into `variables.pkr.hcl`.
* Refactored all builds to use `<build>.auto.pkvars.hcl` for input variables the and `<build>.pkr.hcl` for the template configurations, with simplified names for `<build>`.
* Refactored all builds to use `${path.cwd}/output/` as the path for the manifest post-processor.
* Updated the Rocky Linux build to use UEFI; however without secure boot.
* Refactored all builds to pass the language, keyboard, and timezone to the configuration files.
* Refactored all builds with input variable definitions separated into `variables.pkr.hcl`.
* Refactored all builds to use `<build>.auto.pkvars.hcl` for input variables the and `<build>.pkr.hcl` for the template configurations, with simplified names for `<build>`.
* Refactored all builds to use `${path.cwd}/output/` as the path for the manifest post-processor.
@tenthirtyam tenthirtyam merged commit a982647 into vmware-samples:main Sep 16, 2021
@tenthirtyam tenthirtyam deleted the release-21-09-1 branch September 16, 2021 02:10
@tenthirtyam tenthirtyam self-assigned this Sep 16, 2021
@tenthirtyam tenthirtyam added type/docs Documentation type/enhancement Enhancement type/refactor Refactor labels Sep 16, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/docs Documentation type/enhancement Enhancement type/refactor Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant