Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for disk-based deployment mode for Debian 11 #272

Merged

Conversation

ukushisanet
Copy link
Contributor

Summary of Pull Request

Debian 11 was introduced to the project in the v22.08 release with only support for HTTP-based deployment only.

This PR will add the enhancement for disk-based deployment support and fix issue #261 as discussed with @tenthirtyam in comments.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

The boot_command and the preseed/early_command are determined based on the configuration in the common_data_source variable.

Here is the output of the whole boot sequence with the common_data_source variable set to disk:
data_source_disk

And here is a screenshot of the boot command with the common_data_source variable set to http:
data_source_http

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam
Copy link
Contributor

Many thanks for the contribution and the very detailed pull request, it is much appreciated. I'll review this week and merge if all is a go.

Thank you for being a contributor, I hope you have found the project helpful.

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

@tenthirtyam tenthirtyam changed the title fix: Add support for disk-based deployment mode for Debian 11 (#261) fix: add support for disk-based deployment mode for Debian 11 (#261) Sep 20, 2022
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified in testbed - LGTM! 🚀

@tenthirtyam tenthirtyam changed the title fix: add support for disk-based deployment mode for Debian 11 (#261) fix: add support for disk-based deployment mode for Debian 11 Sep 20, 2022
@tenthirtyam tenthirtyam merged commit cdbc6f7 into vmware-samples:main Sep 20, 2022
tenthirtyam added a commit that referenced this pull request Sep 20, 2022
Updates `CHANGELOG.md` to include enhancement provided in #272.

Signed-off-by: Ryan Johnson <[email protected]>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for disk-based deployment mode for Debian 11
2 participants