Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ansible roles for Linux; address project chores #156

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Add Ansible roles for Linux; address project chores #156

merged 3 commits into from
Feb 7, 2022

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Linux machine images:

  • Adds Ansible roles (users, configure, and clean) for Linux machine image builds. #54
  • Updates GHA to ignore Ansible since the linter errors on a required configuration.

Windows machine images:

  • Condenses Windows machine image scripts.

Chores:

  • Updates to minimum Packer version to v1.7.10.
  • Updates to minimum Terraform version to v1.1.5.
  • Resolve linter issue on CODE_OF_CONDUCT.md.
  • Update dates in LICENSE and NOTICE to 2022.
  • Simplifies terms or phrases in build.sh, config.sh, and set-envvars.sh

Type of Pull Request

  • This is a bugfix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: Closes #34

Test and Documentation Coverage

  • Tests have been completed (for bugfixes / features).
  • Documentation has been added / updated (for bugfixes / features).

- Adds Ansible roles (`users`, `configure`, and `clean`) for Linux machine image builds. #54
- Updates GHA to ignore Ansible since the linter errors on a required configuration.
- Updates to minimum Packer version to `v1.7.10`.

Signed-off-by: Ryan Johnson <[email protected]>
- Condenses Windows machine image scripts.
- Simplifies terms or phrases in `build.sh`, `config.sh`, and `set-envvars.sh`
- Updates to minimum Terraform version to `v1.1.5`.

Signed-off-by: Ryan Johnson <[email protected]>
- Resolve linter inssure on` CODE_OF_CONDUCT.md`.
- Update dates in `LICENSE` and `NOTICE`.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added type/docs Documentation type/enhancement Enhancement priority/low Low Priority sev/low Low size/m Medium type/chore Chore labels Feb 7, 2022
@tenthirtyam tenthirtyam self-assigned this Feb 7, 2022
@github-actions github-actions bot added size/xl X-Large and removed size/m Medium labels Feb 7, 2022
Copy link
Contributor Author

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tenthirtyam tenthirtyam merged commit 12d5c48 into vmware-samples:main Feb 7, 2022
@tenthirtyam tenthirtyam deleted the f-ansible-linux branch February 14, 2022 04:24
@tenthirtyam tenthirtyam added this to the v22.02 milestone Feb 14, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/low Low Priority sev/low Low size/xl X-Large type/chore Chore type/docs Documentation type/enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant