Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certificates to use only .cer PEM encoded files #137

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Update certificates to use only .cer PEM encoded files #137

merged 1 commit into from
Oct 27, 2021

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Context of the Pull Request*

  • Updates all builds to use PEM encoded trusted root authority certificates in.cer format.
  • Updates all .ps1 scripts and Ansible plays to use PEM encoded trusted root authority certificates in.cer format.
  • Removes root-ca.p7b.example in certificates/.
  • Renames root-ca.crt.example in ansible/roles/base/files/.
  • Updates the README.md.

Thanks to @gcblack for being the catalyst for this update.

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

- Updates all builds to use PEM encoded trusted root authority certificates in`.cer` format.
- Updates all `.ps1` scripts and Ansible plays to use PEM encoded trusted root authority certificates in`.cer` format.
- Removes `root-ca.p7b.example` in `certificates/`.
- Renames `root-ca.crt.example` in `ansible/roles/base/files/`

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam self-assigned this Oct 27, 2021
@tenthirtyam tenthirtyam merged commit b79a6a1 into vmware-samples:main Oct 27, 2021
@tenthirtyam tenthirtyam deleted the update-certificates branch October 27, 2021 17:00
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant