Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set host keys to generate on first-boot #129

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Set host keys to generate on first-boot #129

merged 1 commit into from
Oct 14, 2021

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Addressing an issue noticed by @markpeek.

Changes ensure the host keys are cleaned and are generated on the first-boot for uniqueness.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Context of the Pull Request*

  • For RHEL/RHEL derivative and Photon OS the host keys are removed during cleanup (rm -f /etc/ssh/ssh_host_*) and automatically, by default, are regenerated on the first-boot.

  • For Ubuntu, the host keys are removed during cleanup (rm -f /etc/ssh/ssh_host_*) and an /etc/rc.local is added to regenerate on first-boot. Later, if the host keys are missing for any reason, they will be regenerated on reboot. If present, no action.

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Sets host keys to generate on first-boot.
@tenthirtyam tenthirtyam self-assigned this Oct 14, 2021
@tenthirtyam tenthirtyam merged commit 4bfe1f6 into vmware-samples:main Oct 14, 2021
@tenthirtyam tenthirtyam deleted the fix-host-keys branch October 14, 2021 13:55
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant