Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rhel/rhel-derivative kickstart configurations and scripts #110

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Update rhel/rhel-derivative kickstart configurations and scripts #110

merged 1 commit into from
Oct 5, 2021

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Updates rhel/rhel-derivative kickstart configurations and scripts

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Context of the Pull Request*

  • Adds header to kickstart configurations.
  • Adds comments for easier reference.
  • Adds logical volume with partitions that aim to follow CIS partition rules.
  • Moves the generated cleanup script to /home/$BUILD_USERNAME/ due to noexec on /tmp.

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

- Adds header to kickstart configurations.
- Adds comments for easier reference.
- Adds logical volume with partitions that aim to follow CIS partition rules.
- Moves the generated cleanup script to `/home/$BUILD_USERNAME/` due to `noexec` on `/tmp`.
Copy link
Contributor Author

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Self Reviewed
✅ Self Approved

@tenthirtyam tenthirtyam merged commit b4104d8 into vmware-samples:main Oct 5, 2021
@tenthirtyam tenthirtyam deleted the update-rhel-kickstart-scripts branch October 5, 2021 04:43
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/medium Priority Medium sev/low Low size/m Medium type/enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant