This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Create helper for logs and add documentation #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwitzel3
suggested changes
Aug 26, 2021
lenriquez
force-pushed
the
issue-816
branch
4 times, most recently
from
9b54253
to
17b7b10
Compare
| @@ -42,13 +42,35 @@ rm ~/.config/octant/plugins/octant-sample-plugin | |||
|
|
|||
| After deleting the plugin binary and restarting Octant, you should no longer see the plugin available as part of Octant. | |||
|
|
|||
| ## Logs | |||
|
|
|||
| Octant use go-plugin library, this library allows "Any plugins that use the log standard library will have log data automatically sent to the host process." by default with granularity level INFO, to set the log's granularity Octant provides a LoggerHelper that can be use this way. | |||
There was a problem hiding this comment.
Nit: uses go-plugin (maybe link to repo)
wwitzel3
approved these changes
Sep 1, 2021
lenriquez
force-pushed
the
issue-816
branch
2 times, most recently
from
b737a52
to
ae6c95c
Compare
Signed-off-by: Luis Enriquez <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luis Enriquez [email protected]
What this PR does / why we need it:
Plugin Developer would like to know how to use logs inside of a plugin
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: