This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Show error for JS plugin watcher #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtreme-vikram-yadav
force-pushed
the
issue-1273
branch
3 times, most recently
from
b8eeec3
to
6bc2d22
Compare
There was a problem hiding this comment.
Can you renamed the colliding variable name and import event on https://github.com/vmware-tanzu/octant/blob/master/pkg/plugin/manager.go#L395 ?
@GuessWhoSamFoo how did you even spot that from this diff? Nice!! |
Signed-off-by: Vikram Yadav <[email protected]> vmware-archive#1273
xtreme-vikram-yadav
force-pushed
the
issue-1273
branch
from
6bc2d22
to
0666cae
Compare
- Do not error out from octant when plugin startup fails Signed-off-by: Vikram Yadav <[email protected]> vmware-archive#2796
xtreme-vikram-yadav
force-pushed
the
issue-1273
branch
from
6350d9e
to
f264f57
Compare
wwitzel3
approved these changes
Aug 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes