This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Reconciles unmarshal and base code differences #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents some errors when attempting to unmarshal components Signed-off-by: Liam Rathke <[email protected]> Signed-off-by: Liam Rathke <[email protected]>
|
Please add a changelog entry for this. |
|
Sorry, for reference, instructions are here: https://github.com/vmware-tanzu/octant/blob/master/CONTRIBUTING.md#changelog |
Signed-off-by: Liam Rathke <[email protected]>
Signed-off-by: Liam Rathke <[email protected]>
GuessWhoSamFoo
approved these changes
Jul 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, complex resource viewer graphs sent to Octant via a TypeScript plugin cannot be displayed, as Octant's
unmarshal.gois unaware of what to do with certain resource viewer components. This PR updatesunmarshal.goto handle all current component type constants handled inbase.go, and reorders the content of both files alphabetically.Kudos to @mklanjsek for debugging and helping me find the solution!
Testing steps:
To test this example, we'll use a sample TypeScript plugin that displays data in an Octant resource viewer
Release note: