This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Websocket Streaming Interface #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Stergianis <[email protected]>
There was some incorrect error handling in my last commit. When fixing that I noticed that I slightly changed the semantics of the websocket read pump when I moved unmarshaling to be a client.Recieve responsibility. So I introduced a new concept that a stream client can return a fatal error, and read pump can react to that appropriately. This paves the way for read pump to become a function owned by the streaming client manager instead of a method on websocket client. Signed-off-by: Michael Stergianis <[email protected]>
- change for loop semantics in (*StreamingConnectionManager).Run Signed-off-by: Michael Stergianis <[email protected]>
Signed-off-by: Wayne Witzel III <[email protected]>
Allows library implementations of StreamClient and StreamClientFactory to return fatal StreamErrors Signed-off-by: Michael Stergianis <[email protected]>
Signed-off-by: Michael Stergianis <[email protected]>
Signed-off-by: Michael Stergianis <[email protected]>
Signed-off-by: Wayne Witzel III <[email protected]>
|
I think this is now in its final form @MichaelStergianis @jamieklassen I've rebased, made some minor refactors, and also ensured all of the Michael's recent changes in his branch have been added in as well. |
mstergianis
reviewed
Jun 22, 2021
Signed-off-by: Wayne Witzel III <[email protected]>
|
@GuessWhoSamFoo could use a review on this. |
GuessWhoSamFoo
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Depending on merge order, this one or #2566 will need a rebase
|
Hey @GuessWhoSamFoo , is it possible to get this one in first please? =) |
|
The other PR is a dependency update with regenerated mock files so it should not block (and trivial to rebase if we want both) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Replaces #2504 and #1905
Which issue(s) this PR fixes