Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Tabs Component #2482

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Tabs Component #2482

merged 1 commit into from
Jun 3, 2021

Conversation

ftovaro
Copy link
Contributor

@ftovaro ftovaro commented May 21, 2021

Signed-off-by: ftovaro [email protected]

What this PR does / why we need it:
Creates tabs component

image

Which issue(s) this PR fixes

Special notes for your reviewer:

Release note:

release-note

@ftovaro ftovaro force-pushed the issue-2304 branch 27 times, most recently from a2a7de8 to 5e4d69a Compare May 27, 2021 20:55
@ftovaro ftovaro force-pushed the issue-2304 branch 3 times, most recently from f016f8a to b71bf74 Compare June 1, 2021 16:49
Copy link
Contributor

@mklanjsek mklanjsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few small changes in presentation layer.

@mklanjsek
Copy link
Contributor

@ftovaro sorry for late addition, but that button can't touch the tabs in horizontal layout - there needs to be some spacing around app-view-container. The easiest way to deal with that would be to wrap it inside div and conditionally set the top margin to 8 px for horizontal layout.

@ftovaro
Copy link
Contributor Author

ftovaro commented Jun 3, 2021

@mklanjsek Thanks, I was dealing with that and with your comment I solved easily.

image

Copy link
Contributor

@mklanjsek mklanjsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Signed-off-by: ftovaro <[email protected]>
@mklanjsek mklanjsek merged commit 788c184 into vmware-archive:master Jun 3, 2021
@ftovaro ftovaro deleted the issue-2304 branch June 3, 2021 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add horizontal tabs clarity component
3 participants