This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Added SelectFile component #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milan Klanjsek <[email protected]>
pkg/view/component/select_file.go
Outdated
| @@ -0,0 +1,68 @@ | |||
| package component | |||
|
|
|||
| import "encoding/json" | |||
There was a problem hiding this comment.
We want to use "github.com/vmware-tanzu/octant/internal/util/json" here
lenriquez
reviewed
May 14, 2021
|
|
||
| @Component({ | ||
| selector: 'app-view-select-file', | ||
| templateUrl: './select-file.component.html', |
There was a problem hiding this comment.
I wonder if it should switch the change detection to "ChangeDetectionStrategy.OnPush"?
There was a problem hiding this comment.
I was considering it, but since it’s a simple component, I decided to keep it simple for now.
|
👍 |
Signed-off-by: Milan Klanjsek <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new SelectFile component intended to be used to select file(s) from the file system.
Also added this new file selector to apply yaml, so it's now possible to select and open a yaml file before applying it. While there, I refactored the form buttons to use
cds-buttonand be consistent with the FileSelect button.Signed-off-by: Milan Klanjsek [email protected]