Update tray menu #2411
Update tray menu #2411
Conversation
| menu.append(new MenuItem({label: 'View Logs', type: 'normal', click: () => shell.showItemInFolder(errLogPath)})); | ||
|
|
||
| menu.append(this.contextSubMenu()); | ||
| menu.append(this.aboutOctantSubMenu()); |
There was a problem hiding this comment.
Can we just have About Octant menu item here that opens the same modal as when invoked from header. I feel it's important to have consistent interface, plus the version and build strings look wonky showing up in sub-menus like that.
There was a problem hiding this comment.
What you are asking makes sense. Opening the same modal in the app window may not work well when there is only tray without any open window. I briefly looked into showing a native about panel to show this information but decided to use menu item as not all the provided options are supported across different OSes. But thanks to your comment, I tried it with a work around which shows the info properly. I have updated the implementation, it is not how about panels options are meant to be used but it works for now.
xtreme-vikram-yadav
force-pushed
the
update-tray
branch
from
95d274e
to
63c2193
Compare
Signed-off-by: Vikram Yadav <[email protected]>
xtreme-vikram-yadav
force-pushed
the
update-tray
branch
from
63c2193
to
57b0f40
Compare
What this PR does / why we need it: This PR adds the following menu items to tray:
'Contexts' (Shows cluster contexts and allows context switching'
'About Octant' (copied from header)
'Open an Issue' (copied from header)
'Octant Documentation' (copied from header).
Tray icon is also updated to greyscale icon.
Which issue(s) this PR fixes