Overhaul of Octant storybook implementation #2386
Conversation
|
The deploy preview is failing because this needs a rebase to include the nelify.toml move from eb94d63 |
Signed-off-by: Milan Klanjsek <[email protected]>
Signed-off-by: Milan Klanjsek <[email protected]>
Signed-off-by: Milan Klanjsek <[email protected]>
web/src/stories/graph.stories.ts
Outdated
| @@ -12,6 +10,11 @@ import { | |||
| Service, | |||
| ServiceAccount, | |||
| } from '../app/modules/shared/components/presentation/cytoscape2/shape'; | |||
| import { Meta, Story } from '@storybook/angular/types-6-0'; | |||
|
|
|||
| export default { | |||
There was a problem hiding this comment.
This should be moved to a common file along with the export in new.graph.stories.ts
There was a problem hiding this comment.
Good point, Other/Resources was double entry, it's fixed now.
| header: "current header", | ||
| title: 'Step 1', | ||
| description: 'this is a current step', | ||
| buttonGroup: buttonGroupView, |
There was a problem hiding this comment.
The button group will need to be updated as the schema for buttons have changed.
There was a problem hiding this comment.
Updated button definition
| component: AccordionComponent, | ||
| }} | ||
| <Story name="Accordion component" | ||
| component={AccordionComponent} |
There was a problem hiding this comment.
Can another issue be opened to track removing component from each story? Probably will need to be done manually as it might be hard to script this.
There was a problem hiding this comment.
You are right, I missed that. All Component entries are now removed from MDX stories.
Signed-off-by: Milan Klanjsek <[email protected]>
|
@GuessWhoSamFoo PTAL |
There was a problem hiding this comment.
We are still seeing warnings for storyFn at 6.3: storybookjs/storybook#13074
Not a blocker, but something to watch when storybook 7 comes out.
|
Sounds good, I am not seeing these but will keep an eye on them. |
The intention of this work was to provide better performance of our Storybook portal by using the newly released Storybook inline mode for angular components. However, it turned out that much more serious surgery was required to make everything working at that level, resulting in pretty much overhaul of internal Storybook organization.
storiesOffmodel and use the hoisted annotationsknobsaddon (has issues with inline stories) with the new generationcontrolsaddon that supports editing in both Docs and Canvas mode