This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Expose Delete and Create object store calls for Go Plugins #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [vmware-archive#1599] Signed-off-by: vikram yadav <[email protected]>
xtreme-vikram-yadav
force-pushed
the
go-plugins-dashboard-parity
branch
from
0c131b6
to
a443128
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR creates/exposes Create and Delete Calls for Go plugins to interact with the object store.
Which issue(s) this PR fixes
Special notes for your reviewer:
Create Call was already available(https://github.com/vmware-tanzu/octant/blob/9b658f64342cb6cb8388f689dc61a39cb79de4e5/pkg/plugin/api/server.go#L270).
It just wasn't exposed via Dashboard interface (https://github.com/vmware-tanzu/octant/blob/master/pkg/plugin/service/dashboard.go).