Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Bump to Clarity 5 #2222

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Bump to Clarity 5 #2222

merged 3 commits into from
Mar 30, 2021

Conversation

mklanjsek
Copy link
Contributor

Updated our project to use Clarity 5.1.0 and fixed some compatibility issues:

  • Fixed broken styles in storybook docs,
  • Reworked left navigation colors to keep them as before,
  • Added workaround for navigation icon issue (until it's fixed by clarity folks),
  • Verified with @lenriquez that Icon component works properly,
  • Also fixed annoying flicker in Storybook stories where components were initially updated in dark theme

Signed-off-by: Milan Klanjsek [email protected]

@wwitzel3 wwitzel3 added this to In progress in 0.19 via automation Mar 25, 2021
@lenriquez
Copy link
Contributor

Could you pls add the change log? :)

Signed-off-by: Milan Klanjsek <[email protected]>
@@ -0,0 +1 @@
Upgraded project to Clarity 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking: Header spacing changes here (top -> 0.18, bottom -> current):

image

0.19 automation moved this from In progress to Reviewer approved Mar 30, 2021
@GuessWhoSamFoo GuessWhoSamFoo merged commit 784e95f into vmware-archive:master Mar 30, 2021
0.19 automation moved this from Reviewer approved to Done Mar 30, 2021
@xtreme-vikram-yadav xtreme-vikram-yadav mentioned this pull request Apr 21, 2021
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
0.19
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants