This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Update component dynamically if view type changes #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milan Klanjsek <[email protected]>
|
@GuessWhoSamFoo I believe this should fix the problems you were seeing with disappearing heptagons |
GuessWhoSamFoo
approved these changes
Mar 24, 2021
This was referenced Mar 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent Resource Viewer change uncovered problems with updating the object status component. After Resource Viewer selection has been changed, the status view was not updated when component of different type had to be used, so for example we were missing heptagon indicators in some cases. This change is fixing that by checking the view type and forcing the update if new view has different type.
Signed-off-by: Milan Klanjsek [email protected]