This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Extract store metadata sent by Go plugins #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Second value is ignored as metadata is always set by grpc. | ||
| md, _ := metadata.FromIncomingContext(ctx) | ||
| for k, v := range md { | ||
| if strings.HasPrefix(k, "x-octant-") { |
There was a problem hiding this comment.
This is something up for discussion. grpc metadata does not allow strings to be wrapped by type and strictly accept string. This is the convention i used here to avoid octant from loading header like content-type, user-agent into the context which are subject to change in the future.
xtreme-vikram-yadav
force-pushed
the
go-plugins-context
branch
2 times, most recently
from
7e956ea
to
57ce9d0
Compare
Signed-off-by: Vikram Yadav <[email protected]>
xtreme-vikram-yadav
force-pushed
the
go-plugins-context
branch
from
57ce9d0
to
7b266da
Compare
wwitzel3
approved these changes
Mar 13, 2021
There was a problem hiding this comment.
This looks good.
Could you add a note about somewhere in https://github.com/vmware-tanzu/octant/blob/master/web/src/stories/docs/plugins/GoPluginsIntro.story.mdx .. like a "Other" section or something or .. "Custom Runtimes"
Signed-off-by: Vikram Yadav <[email protected]>
xtreme-vikram-yadav
force-pushed
the
go-plugins-context
branch
from
cbbb3e4
to
5393d8a
Compare
wwitzel3
approved these changes
Mar 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vikram Yadav [email protected]
What this PR does / why we need it: It allows octant to extract out contextual data sent by the Go plugins. This data is intended to be used by object stores.
Related PR: #2099