This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Add electron build pipelines for nightly and release #1827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Special notes for your reviewer:
Additional changes (in future PRs) which should follow:
goreleaser/goreleaser-action@v2
. The action now allows an install-only mode to handle any pre-processing in the same runner. This can skip the upload/download steps for bundled assets files.actions/upload-release-asset@v1
. Although goreleaser supports uploading arbitrary files (feat: upload extra files to the release goreleaser/goreleaser#1333), it needs post processing ofchecksums.txt
before upload which is not supported.electron-builder
enforces semver inpackage.json
so version bumps need to happen in two places. Documentation and/or automation is needed to avoid potential mismatch.go build ...
.