Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Add electron build pipelines for nightly and release #1827

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Conversation

GuessWhoSamFoo
Copy link
Contributor

Which issue(s) this PR fixes

Special notes for your reviewer:
Additional changes (in future PRs) which should follow:

  • Switch from using goreleaser containers in asset building to goreleaser/goreleaser-action@v2. The action now allows an install-only mode to handle any pre-processing in the same runner. This can skip the upload/download steps for bundled assets files.
  • Wait for glob support on actions/upload-release-asset@v1. Although goreleaser supports uploading arbitrary files (feat: upload extra files to the release goreleaser/goreleaser#1333), it needs post processing of checksums.txt before upload which is not supported.
  • Ensure octant node subprocess can access local filesystem/env vars. The octant subprocess in electron does not have access to the local filesystem or environment variables and asks for a kubeconfig each time.
  • Synchronize version across front and backend code. electron-builder enforces semver in package.json so version bumps need to happen in two places. Documentation and/or automation is needed to avoid potential mismatch.
  • Investigate high CPU usage. Something about running octant in this mode is causing CPU spikes at launch.
  • Electron nightlies are relatively large files so the current behavior is to overwrite old uploads.
  • Add a build flag to exclude front end bundles from go build ....

@GuessWhoSamFoo GuessWhoSamFoo changed the title Electron builder Add electron build pipelines for nightly and release Jan 15, 2021
Copy link
Contributor

@wwitzel3 wwitzel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, one minor fix that will also remove a TODO item and this is ready to merge.

web/main.ts Show resolved Hide resolved
GuessWhoSamFoo and others added 3 commits January 19, 2021 10:37
Signed-off-by: GuessWhoSamFoo <[email protected]>
Co-authored-by: Wayne Witzel III <[email protected]>
@wwitzel3 wwitzel3 merged commit 8d13159 into master Jan 19, 2021
@GuessWhoSamFoo GuessWhoSamFoo deleted the electron-builder branch February 9, 2021 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add build-electron-prod to build.go
2 participants