This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Fix streamer flake #1797
Merged
Fix streamer flake #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GuessWhoSamFoo <[email protected]> Co-Authored-by: Wayne Witzel III <[email protected]>
|
I love the irony of a test flake fix failing due to a different test flake. |
wwitzel3
approved these changes
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a test flake which had two possible failures: timing out or a nil message.
If the go routine in the test fails before completion, the test would block indefinitely. Alternatively,
createEventis called twice - the handler and instantiation of the streamer. The unnecessary call is now removed.Results of this test are now reproducible:
Which issue(s) this PR fixes
Signed-off-by: GuessWhoSamFoo [email protected]
Co-Authored-by: Wayne Witzel III [email protected]