This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Only show preferred version of custom resources #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwitzel3
approved these changes
Dec 15, 2020
|
This looks good to me, @GuessWhoSamFoo if you have a moment to try it out, I'd like your feedback here as well. |
wwitzel3
suggested changes
Dec 16, 2020
bryanl
force-pushed
the
preferred-custom-resource-version
branch
from
ca60a72
to
d717e2b
Compare
Bumps [actions/setup-node](https://github.com/actions/setup-node) from v2.1.2 to v2.1.3. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2.1.2...27082ce) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [core-js](https://github.com/zloirock/core-js) from 3.6.5 to 3.8.1. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](zloirock/core-js@v3.6.5...v3.8.1) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.3 to 7.12.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.10/packages/babel-core) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [marked](https://github.com/markedjs/marked) from 1.2.4 to 1.2.6. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v1.2.4...v1.2.6) Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Milan Klanjsek <[email protected]>
Signed-off-by: Milan Klanjsek <[email protected]>
Bumps [stefanzweifel/git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action) from v4.7.2 to v4.8.0. - [Release notes](https://github.com/stefanzweifel/git-auto-commit-action/releases) - [Changelog](https://github.com/stefanzweifel/git-auto-commit-action/blob/master/CHANGELOG.md) - [Commits](stefanzweifel/git-auto-commit-action@v4.7.2...75802d2) Signed-off-by: dependabot[bot] <[email protected]>
When a CRD has multiple defined versions, they are all shown. This is distracting and confusing for Octant users. Instead only show the preferred version, and if multiple versions exist, show them in the summary for a custom resource. Signed-off-by: bryanl <[email protected]>
bryanl
force-pushed
the
preferred-custom-resource-version
branch
from
d717e2b
to
ae257ae
Compare
|
Something weird happened on the rebase, but the core changes look fine to me. |
wwitzel3
approved these changes
Dec 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bryanl [email protected]
What this PR does / why we need it:
When a CRD has multiple defined versions, they are all shown. This is
distracting and confusing for Octant users. Instead, only show the
preferred version, and if multiple versions exist, show them in the
summary for a custom resource.
Which issue(s) this PR fixes
Release note: