This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Allow table sorting by multiple keys #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuessWhoSamFoo
force-pushed
the
sort-status
branch
2 times, most recently
from
84e5c1a
to
8fe97ca
Compare
GuessWhoSamFoo
changed the title
GuessWhoSamFoo
force-pushed
the
sort-status
branch
from
7200a9f
to
4545b2f
Compare
GuessWhoSamFoo
force-pushed
the
sort-status
branch
2 times, most recently
from
f60963a
to
0f97b36
Compare
GuessWhoSamFoo
changed the title
|
there was discussion about how this might look more maintainable if we separated out the reverse param into its own method and have a sort that only requires one or more keys |
GuessWhoSamFoo
force-pushed
the
sort-status
branch
3 times, most recently
from
9e33184
to
331d2a0
Compare
|
Added |
wwitzel3
approved these changes
Nov 20, 2020
wwitzel3
approved these changes
Nov 20, 2020
added 3 commits
November 24, 2020 10:51
Signed-off-by: GuessWhoSamFoo <[email protected]>
Signed-off-by: GuessWhoSamFoo <[email protected]>
Signed-off-by: GuessWhoSamFoo <[email protected]>
GuessWhoSamFoo
force-pushed
the
sort-status
branch
from
331d2a0
to
3d17175
Compare
|
@alexbrand Sorry this took a while to get merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds sorting with multiple keys and sorts items with an error status by default in order to increase visibility of unhealthy cluster items.This is a breaking API change astable.Sortis inpkgSince datagrids are paginated, this results in a poor user experience if the status of an object changes while a user is looking at it. We will need to rethink if the goal should be filtering instead.
Which issue(s) this PR fixes
Signed-off-by: GuessWhoSamFoo [email protected]