Merge pull request #2376 from lenriquez/issue-2020

Horizontal stacking of fields
vmware-archive · Jun 3, 2021 · 68df9b7 · 68df9b7
2 parents 788c184 + 331ef55
commit 68df9b7
Show file tree

Hide file tree

Showing 22 changed files with 826 additions and 929 deletions.
diff --git a/changelogs/unreleased/2020-lenriquez b/changelogs/unreleased/2020-lenriquez
@@ -0,0 +1 @@
+Horizontal stacking of fields
diff --git a/cmd/octant-sample-plugin/main.go b/cmd/octant-sample-plugin/main.go
@@ -233,6 +233,7 @@ func initRoutes(router *service.Router) {
  form := component.Form{Fields: []component.FormField{
  component.NewFormFieldHidden("action", pluginActionName),
  }}
+
  testButton := component.Action{
  Name: "Test Button",
  Title: "Test Button",

diff --git a/pkg/view/component/base.go b/pkg/view/component/base.go
@@ -36,6 +36,8 @@ const (
  TypeExpressionSelector = "expressionSelector"
  // TypeFlexLayout is a flex layout component.
  TypeFlexLayout = "flexlayout"
+ // TypeFormField is a form field component.
+ TypeFormField = "formField"
  // TypeGraphviz is a graphviz component.
  TypeGraphviz = "graphviz"
  // TypeGridActions is a grid actions component.

diff --git a/pkg/view/component/container.go b/pkg/view/component/container.go
@@ -49,6 +49,6 @@ type containersMarshal Containers
 // MarshalJSON implements json.Marshaler
 func (t *Containers) MarshalJSON() ([]byte, error) {
  m := containersMarshal(*t)
- m.Metadata.Type = "containers"
+ m.Metadata.Type = TypeContainers
  return json.Marshal(&m)
 }