Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enable/disable speaker and microphone from UI #56

Merged
merged 6 commits into from
Sep 6, 2023

Conversation

Adarsha-gg
Copy link
Collaborator

Solves issuse: #51 with commit: bff4eac

Addition of a new UI for enabling disabling microphone/speaker as per need.

@vivekuppal vivekuppal changed the title Allow enable/disable speaker and microphone Allow enable/disable speaker and microphone from UI Aug 31, 2023
@vivekuppal
Copy link
Owner

Recommend to implement the functionality as Menu options.
Attempting to reduce the number of buttons in the UI. Several of the other buttons have been moved to File Menu as well.
E.g could do Edit -> Speaker Enabled, Edit -> Microphone Enabled

The button click behavior works correctly.

Start with the following cmd line arguments
- python main.py -ds
Speaker button should say Speaker Disabled, currently it says speaker enabled
Similar behavior for microphone for -dm option

@Adarsha-gg
Copy link
Collaborator Author

Improvements in commit: [ab7a0b8]

Merged the two functionalities into a single button -> Menu. Using command line arguments doesnt break the button.

Only problem is the arguments code has been moved down in the main.py file to 151. I couldn't find a way to intialize the variable without altering the code structure a little bit.

@Adarsha-gg
Copy link
Collaborator Author

Improvements in commit: [2025a84]

Removed the "Menu" button and added the enable/disable speaker/microphone to the edit button at top of the application.
It is compatible with system arguments such as -ds and -dm.

@vivekuppal vivekuppal self-requested a review September 4, 2023 14:35
README.md Outdated
@@ -104,7 +104,7 @@ Run ```generate_binary.bat``` file by replacing paths at the top of the file to

1. Download the zip file from
```
https://drive.google.com/file/d/1UJR4rJt5umxxOiAHNGXPMhnnYr6Bj6fX/view?usp=sharing
Copy link
Owner

@vivekuppal vivekuppal Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming that the changes in the binary correspond to the changes in your branch.
If that is the case, binary should always be built from the main branch and you might have to rebuild the binary after this PR is merged to main.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not updated the binaries according to changes in my branch.
Yes I'll rebuild the binaries after this PR is merged

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no change to the binaries, the link should stay the same as before.

@vivekuppal vivekuppal added the enhancement New feature or request label Sep 4, 2023
@vivekuppal vivekuppal merged commit ce5a1e1 into main Sep 6, 2023
2 checks passed
@vivekuppal vivekuppal deleted the allow-enable/disable-speaker-and-microphone branch September 6, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants