Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using API, we do not need to specify language, absorb the lang parameter in the method #24

Merged
merged 2 commits into from
Jul 18, 2023
Merged

When using API, we do not need to specify language, absorb the lang parameter in the method #24

merged 2 commits into from
Jul 18, 2023

Conversation

vivekuppal
Copy link
Owner

Resolves issue #23

abhinavuppal1
abhinavuppal1 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@abhinavuppal1 abhinavuppal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a quick fix.
Better to fix using classes as specified in the comments in code.

@vivekuppal vivekuppal merged commit 901501b into main Jul 18, 2023
@vivekuppal vivekuppal deleted the vu-change-lang-issue branch July 18, 2023 22:01
@vivekuppal vivekuppal added the bug Something isn't working label Jul 19, 2023
@jinnnnnnnnnsd jinnnnnnnnnsd mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavuppal1 abhinavuppal1 abhinavuppal1 approved these changes

Assignees

@vivekuppal vivekuppal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vivekuppal @abhinavuppal1