Disabled winrar UI #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekuppal
reviewed
Jul 18, 2023
| @@ -38,7 +38,9 @@ copy %ASSETS_DIR_SRC%\mel_filters.npz %ASSETS_DIR_DEST% | |||
| copy %ASSETS_DIR_SRC%\gpt2.tiktoken %ASSETS_DIR_DEST% | |||
|
|
|||
| REM Code for zipping the final package | |||
| "%WINRAR%" a -r -ep1 -df "%ZIP_FILE_DIR%" "%ZIP_LOCATION%" | |||
| ECHO Zipping file... | |||
| "%WINRAR%" a -r -ep1 -df -ibck "%ZIP_FILE_DIR%" "%ZIP_LOCATION%" | |||
There was a problem hiding this comment.
With this option UI is being used, albeit it is minimized in the task bar. If an incorrect switch is provided it results in an error pop up that needs to be clicked on.
There was a problem hiding this comment.
Started using rar.exe instead of winrar.exe to avoid UI display.
vivekuppal
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the UI of winrar which may interfare with creation of files using .bat file.