docs: add atk's official solid test case in examples #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: ebac689 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/621be62a2a87f10007fa59d4 😎 Browse the preview: https://deploy-preview-866--vitest-dev.netlify.app |
|
Sorry, forgot to overwrite a local dependency that is already released. Give me a few minutes. Update: done. This can now be merged. We're already part of solid's official testing guide, btw: https://www.solidjs.com/guides/testing#vitest |
atk
force-pushed
the
atk/solid-test-case-2
branch
from
9bfd263
to
ebac689
Compare
sheremet-va
requested changes
Feb 28, 2022
sheremet-va
approved these changes
Feb 28, 2022
patak-dev
changed the title
|
Why is there a package-lock and ui types change in this PR? Should we separate them if they are unrelated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last changes left my branch too detached, so I started anew and now this can serve as an official example. Thank you for your help and patience.