feat(cli): add --no-open option
#635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 6ec3e94 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61f112c2cecd7d0008b7baf1 😎 Browse the preview: https://deploy-preview-635--vitest-dev.netlify.app |
patak-dev
requested changes
Jan 26, 2022
There was a problem hiding this comment.
The option should be called --open. cac supports negated options https://www.npmjs.com/package/cac#negated-options, so we can have --open default to true (but it is only used when --ui is enabled), or the user can set --no-open
patak-dev
approved these changes
Jan 26, 2022
Demivan
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users expressed the desire to run Vitest and its UI in a container.
Since the
--uiflag automatically opens the UI, using the UI in a container results in a crash.This PR adds a
--no-openoption to skip the automatic opening while still exposing the UI.Edit: Currently,options.noOpenwas alwaysundefinedduring my local tests. I'm not sure why though.|