fix: escape $ characters in inline snapshots (fix #597) #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 5c125b8 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61eb0f94f87e7b000778d409 😎 Browse the preview: https://deploy-preview-599--vitest-dev.netlify.app |
sheremet-va
approved these changes
Jan 21, 2022
edimitchel
reviewed
Jan 21, 2022
| @@ -37,6 +37,15 @@ test('inline snapshot', () => { | |||
| .filter(fn) | |||
| " | |||
| `) | |||
| const literal = ` | |||
| Hello \${world} | |||
There was a problem hiding this comment.
Suggested change
| Hello \${world} | |
| Hello ${world} |
No?
There was a problem hiding this comment.
Isn't the thing we need to be escape ?
If we escape already on the Arrange step, this test won't be very significant, no?
There was a problem hiding this comment.
It would not test this bug anyway. Bug only affected generating inline snapshot, not comparing with it.
Will create test today.
There was a problem hiding this comment.
also spaces on each line are trimmed when comparing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #597