fix: fix node crash under Windows (fix #582) #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: e2a00cc 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61e857fdca755f0007090eec 😎 Browse the preview: https://deploy-preview-588--vitest-dev.netlify.app |
Demivan
commented
Jan 19, 2022
Demivan
commented
Jan 19, 2022
sheremet-va
requested changes
Jan 19, 2022
| ) | ||
| setTimeout(() => { | ||
| console.warn(`close timed out after ${CLOSE_TIMEOUT}ms`) | ||
| process.exit() |
There was a problem hiding this comment.
I'm not sure. It does not mean that tests have failed. We weren't returning 1 on timeout before this.
There was a problem hiding this comment.
But it probably does not matter (as this should not happen) and we can have 1 just in case. This way if we have a task that does not finish in time we will get an error and can investigate.
There was a problem hiding this comment.
We actually have some long running stuff and it fails. Need to investigate
This reverts commit c063bac.
|
this changes works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #582