-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add summary #493
Conversation
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 48c0cbd 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61e6554a4fb39e000796e332 😎 Browse the preview: https://deploy-preview-493--vitest-dev.netlify.app |
# Conflicts: # packages/ui/client/components/Navigation.vue # packages/ui/client/components/TasksList.vue
@@ -0,0 +1,96 @@ | |||
<script setup lang="ts"> | |||
const props = defineProps<{ total: number; failed: number; pass: number; inProgress: boolean }>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not destructure this props so you can just use the values directly inside template instead of props.value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
total can be outside the computed i.e const total = unref(total)
since it's been reused in multiple places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@userquin well done 👏👏👏
function getTests(suite: Arrayable<Task>): Test[] { | ||
return toArray(suite).flatMap(s => s.type === 'test' ? [s] : s.tasks.flatMap(c => c.type === 'test' ? [c] : getTests(c))) | ||
} | ||
const tests = computed(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all this computed values should be before methods
we need to fix the scrolls and the new |
Should I work on this @userquin? |
@dammy001 sure, the problem is that some changes breaks the scrolls on code mirrors, and we need to fix them ( We should ask Anthony the |
…serquin/feat-ui-summary # Conflicts: # packages/ui/client/components/FileDetails.vue
Reviewing now |
import type { Task } from '#types' | ||
import { toggleDark } from '~/composables' | ||
import { files, runAll } from '~/composables/client' | ||
import { activeFileId } from '~/composables/params' | ||
|
||
const summaryVisible = injectSummaryVisible() | ||
const showSummary = injectShowSummary() | ||
const currentModule = injectCurrentModule() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for using inject/provide here? I would prefer to directly use global ref/computed for it. We are a SPA so we don't need to worry about the state mixing, I see inject/provide only add complexity but is not really helpful.
there is a flickering on the progress bar on initial load, not all files are collected and there is no way to now when the running files finish |
@antfu @patak-dev : with the new dashboard layout each box will shift when running the tests since the values will make text grow, I have uploaded to discord server on ui room some videos using grid (1 row) and flex (2 columns) (I follow all your instructions). EDIT: I've added/modified some min sizes, gaps and paddings, maybe we can set each entry on its row, the container is a grid. |
@userquin @sheremet-va how do I run the UI? I keep getting this error.
|
@dammy001 after running
EDIT: second approach will start the vite dev server for the UI so use it for development |
@userquin Thanks. |
Very nice work! |
sure, but beware, Anthony is changing the UI and there are no commits yet @antfu any updates here? can you push your local changes (at least resolving conflicts)? |
* feat(useTransition): support for vectors (vitest-dev#376) * refactor(useTransition): cleaning up (vitest-dev#385) * refactor(useWebWorkerFn): Small doc and type improvements (vitest-dev#382) Co-authored-by: Anthony Fu <[email protected]> * feat: pwa reload prompt * chore: update docs * refactor(useWebWorkerFn): Small doc and type improvements (vitest-dev#382) Co-authored-by: Anthony Fu <[email protected]> * chore: update docs * test: simpilfy tests for useTransition * chore: fix tests * feat(useTransition): support for delayed transitions (vitest-dev#386) * feat(useTransition): support for disabled transitions (vitest-dev#436) * feat!: introduce `controls` option * chore: update * chore: update * refactor(useRafFn): remove depreacted APIs * chore: enabled tests for next branch * fix(useFetch)!: allow setting response type before doing request (vitest-dev#454) Co-authored-by: Anthony Fu <[email protected]> * chore: resolve conflicts * feat(useMediaControls): expose source types (vitest-dev#495) * fix(useMediaControls): Removes tracks that have been inserted in html (vitest-dev#493) * chore: release v4.9.3 * fix(usePermission): tolerate error on FireFox * fix(useDevicesList): treat as premssion granted after getUserMedia * chore: release v4.9.4 * chore: fix typo (vitest-dev#502) * feat(useWebSocket): add immediate option (vitest-dev#503) * feat(useAxios): bring API into line with useFetch (vitest-dev#499) * feat(createEventHook): new function (#497) * chore: release v4.10.0 * fix(useMediaControls): Doesn't rewrite default media properties (vitest-dev#500) * feat(useMediaControls): add error event (vitest-dev#509) * feat(useStorage): optimize event handling logic (vitest-dev#505) * feat(useFetch): add afterFetch option, onFetchResponse, and onFetchError (vitest-dev#506) * feat(useWebWoker): return worker (vitest-dev#507) Co-authored-by: Anthony Fu <[email protected]> * fix: Change `onMediaError` to `onSourceError` (vitest-dev#510) * feat(onClickOutside): default to just pointerDown (vitest-dev#508) Co-authored-by: Anthony Fu <[email protected]> Co-authored-by: sibbng <[email protected]> * chore: update docs * chore: release v4.11.0 * fix(onClickOutside): duplicate code (vitest-dev#519) Co-authored-by: Nurettin Kaya <[email protected]> * feat(createEventHook): added interface (vitest-dev#531) * feat(createEventHook): added interface * added types for EventHookOn, EventHookOff, and EventHook trigger * feat(useStorage): allow custom serializer (vitest-dev#528) * feat(useStorage): allow custom serializer * update test * refactor(useMediaControls): Deprecate options that can simply be set as attributes (vitest-dev#514) * useMediaControls: Add `volumechange` event listener * fix: `mute` returned * feat: Deprecate video options: * `poster` * `autoplay` * `preload` * `loop` * `controls` * `playsinline` * `autoPictureInPicture` * fix: Fix deprecated behaviour in demo * fix: Remove deprecated usage from doc * refactor: More polite messages * fix: Remove `console.warn`s * chore: release v4.11.1 * refactor!: remove deprecated apis * chore: add next tag * chore: release v5.0.0-beta.1 * feat: introduce `components` & `directives` (vitest-dev#486) Co-authored-by: Anthony Fu <[email protected]> * docs: re-organize * chore: fix lint * docs: about components * chore: include directives * chore: release v5.0.0-beta.2 * chore: rollback jest * chore: fix docs build * docs: readme for components * docs: add @vueuse/gesture * chore: ship indexes.json * chore: release v5.0.0-beta.3 * feat(typedef): add return typedefs (vitest-dev#543) (vitest-dev#544) * refactor!: change publish strcture and support submodules, close vitest-dev#469 * chore: cleanup stories.tsx * docs: update docs about submodules * chore: fix docs * chore: release v5.0.0-beta.4 * chore: update lock * chore: release v5.0.0-beta.5 * chore: update deps and extend publish memory * refactor: remove `useDeviceLight` * chore: update * chore: fix tests * chore: release v5.0.0-beta.7 * refactor(useWebSocket)!: change immediate default for 5.0.0 (vitest-dev#545) * feat(useIpcRenderer): new add-one & new functions (vitest-dev#547) Co-authored-by: Anthony Fu <[email protected]> * chore: update deps * chore: release v5.0.0-beta.8 * chore: fix docs build * chore(usePointerSwipe): fix typo (vitest-dev#557) * fix(useAuth): now reqiures the auth instance, close vitest-dev#538 * chore: update deps * docs(biSyncRef): fix console output comment (vitest-dev#555) * docs: removed deprecated value from example (vitest-dev#556) * docs(guidlines): added guidelines (vitest-dev#535) * docs: update guidelines * chore: update guidelines Co-authored-by: Scott Bedard <[email protected]> Co-authored-by: Fabian <[email protected]> Co-authored-by: Ismail Gjevori <[email protected]> Co-authored-by: Alex Kozack <[email protected]> Co-authored-by: Shinigami <[email protected]> Co-authored-by: wheat <[email protected]> Co-authored-by: sibbng <[email protected]> Co-authored-by: JserWang <[email protected]> Co-authored-by: Pig Fang <[email protected]> Co-authored-by: ArcherGu <[email protected]> Co-authored-by: Ilya Komichev <[email protected]> Co-authored-by: Daiki Ojima <[email protected]> Co-authored-by: Manaus <[email protected]>
This PR includes: